[EXTERNAL][SROA] Add Stored Value Size Check for Tree-Structured Merge #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhernandez0
approved these changes
Oct 17, 2025
Contributor
dhernandez0
left a comment
dhernandez0
left a comment
There was a problem hiding this comment.
please, can you add the migraphx failure as a test on our CI as well?
Contributor
Author
|
Note for reviewers: once this gets all reviews and passes the CIs I will separate this into two separate commits (one internal, one external) and then merge without squashing |
umangyadav
reviewed
Oct 17, 2025
Comment on lines
+4
to
+5
| if not config.arch.startswith("gfx12"): | ||
| config.excludes = ['mixr-tadd-tadd-quant-dot.mlir'] |
Member
There was a problem hiding this comment.
I think, i've seen this failing on gfx950 as well. Can you try perhaps enabling this test in all the arches ?
Contributor
Author
There was a problem hiding this comment.
I tried that already. The perfConfig that this test requires to hit the failing case doesn't seem to be valid on all architectures (e.g., gfx942) and won't compile
umangyadav
approved these changes
Oct 17, 2025
justinrosner
force-pushed
the
justinr-sroa-fix
branch
2 times, most recently
from
bff6dbd to
9331a57
Compare
2 tasks
justinrosner
force-pushed
the
justinr-sroa-fix
branch
from
9331a57 to
ac6872b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR pulls down a change from upstream LLVM that fixes a crash in SROA that was seen when running the MIGraphX CI: https://github.com/ROCm/rocMLIR-internal/issues/2064
Upstream PR: llvm/llvm-project#162921
Technical Details
The change fixes a bug in the SROA where tree-structured merge optimization was incorrectly applied when the size of the stored value was not a multiple of the new allocated element type size
Test Plan
Test Result
Submission Checklist